refactor(lib): resolve FIXME messages #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove outdated FIXME comments, and resolve FIXME regarding usage of `MaybeUninit`.
seanmonstar
reviewed
Oct 19, 2023
| /* SAFETY: it is safe to go from MaybeUninit array to array of MaybeUninit */ | ||
| let mut headers: [MaybeUninit<httparse::Header<'_>>; MAX_HEADERS] = | ||
| unsafe { MaybeUninit::uninit().assume_init() }; | ||
| let mut headers = [MaybeUninit::<httparse::Header<'_>>::uninit(); MAX_HEADERS]; |
There was a problem hiding this comment.
Does this result in the same generated code? Or at least same performance? I mean, logically it makes sense. But it doesn't initialize an array to then declare the stuff inside is uninitialized, right?
There was a problem hiding this comment.
The generated code in debug-mode is slightly different, but in release mode it's identical. Here is a link to the assembly: https://godbolt.org/z/6rvbz8qWd
seanmonstar
approved these changes
Oct 20, 2023
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
Remove outdated FIXME comments, and resolve FIXME regarding usage of `MaybeUninit`.
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
Remove outdated FIXME comments, and resolve FIXME regarding usage of `MaybeUninit`. Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove outdated FIXME comments, and resolve FIXME regarding usage of
MaybeUninit.Since hyper's MSRV is higher now, we can use some new stabilized apis. I also removed some
unsafeblocks related toMaybeUninitusage.